Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service-registry-api): add service-registry-api package #610

Merged
merged 13 commits into from
Sep 18, 2024
Merged

feat(service-registry-api): add service-registry-api package #610

merged 13 commits into from
Sep 18, 2024
+392 −317

Conversation

maancham
Copy link
Contributor

@maancham maancham commented Sep 9, 2024

Description

AXE-4789

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@cjcobb23
Copy link
Contributor

cjcobb23 commented Sep 9, 2024

why do we need this?

@cgorenflo
Copy link
Contributor

why do we need this?

to break the cyclic dependency between service-registry and coordinator

@cjcobb23
Copy link
Contributor

why do we need this?

to break the cyclic dependency between service-registry and coordinator

For what exactly? Is there a planned change that will create a cyclic dependency?

@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.09910% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.63%. Comparing base (2b2aa47) to head (ed9d4fa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/service-registry-api/src/msg.rs 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #610   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files         238      240    +2     
  Lines       33860    33870   +10     
=======================================
+ Hits        31704    31714   +10     
  Misses       2156     2156

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maancham maancham marked this pull request as ready for review September 10, 2024 22:40
@maancham maancham requested a review from a team as a code owner September 10, 2024 22:40
@maancham maancham changed the title feat: add service-registry-api package feat(service-registry-api): add service-registry-api package Sep 11, 2024
cgorenflo
cgorenflo requested changes Sep 13, 2024
View reviewed changes
packages/service-registry-api/src/msg.rs Outdated Show resolved Hide resolved
packages/service-registry-api/src/primitives.rs Outdated Show resolved Hide resolved
packages/service-registry-api/src/primitives.rs Outdated Show resolved Hide resolved
packages/service-registry-api/src/primitives.rs Outdated Show resolved Hide resolved
@maancham maancham merged commit 6bc955b into main Sep 18, 2024
6 checks passed
@maancham maancham deleted the feat/service-registry-api-package branch September 18, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgorenflo cgorenflo cgorenflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maancham @cjcobb23 @cgorenflo